test(cmd): assert what commands actually send to the API - #65

Cover the finalize decision, cancel/get request IDs, list params, submit
payload, the validateSubmitFields call site, the non-TTY guards on
get/approve/reject, the CSP-only GCP rejection, and login's auto-configure
branch and authenticate flags.

Add argument and guard coverage for elevateCloud/elevateGroup/resolveAndElevate
payloads, the four grant env --favorite paths, ErrorInfo handling, the three
empty-results guards, total multi-CSP failure, env's fresh post-prompt context,
the auth cache flag, selector input and --group/--groups precedence. Extract
shouldShowVerboseHint so the hint condition is testable without restating it,
drop a duplicated multi-CSP case and widen the concurrency bound.

All 42 argument-capture rows reverified fail-to-pass with -count=1; records
the mutation forms used where the literal form does not compile.

Extracting shouldShowVerboseHint made the predicate testable but left the
call site unpinned: executeWithHint calls the same predicate, so deleting
the whole if-block from Execute() kept go test ./cmd/ green.

TestIntegration_VerboseHint drives the compiled binary and asserts the
hint is present on a runtime error and absent for an unknown subcommand,
an unknown flag, and an already-verbose run.

TestRunRequestSubmit_MissingFlags_NonInteractive relied on go test's
ambient non-TTY stdin, the one violation of the MUST added in PR4. It
fails under a forced TTY; withInteractiveTTY(t, false) makes the
precondition its name already claims an assertion.

Also switches the GCP negative assertion to len(submitCalls) != 0, which
distinguishes 'never called' from 'called with nil'.

TestRunLogin_AutoConfiguresMissingProfile reaches runConfigure, and
survey writes prompts straight to os.Stdout rather than the cobra
buffer, so every go test ./cmd/ emitted control sequences. One of them,
ESC[6n, makes the terminal reply on stdin and corrupt the shell prompt.

withDiscardedStdout redirects os.Stdout for the test's duration,
restoring it via t.Cleanup, with no production prompt seam.

The CLAUDE.md note claimed the old production cmd/test_helpers.go
'linked test-only code into the binary'. It did not: that file imported
only bytes and cobra, and 'go list -deps . | rg testing' matches on
neither the base nor HEAD. The move was preventive.

The two remaining lastSubmit() != nil negatives become
len(submitCalls) != 0, matching the elevateCalls form already used in
the env tests and distinguishing 'never called' from 'called with nil'.

cmd/test_mocks.go was 443 lines of test scaffolding compiled into the
production cmd package. The same argument that moved test_helpers.go
applies with more force here: this is the larger and faster-growing of
the two files.

go list -deps . | grep -c '^testing$' stays 0.

…mbers

Extracting shouldShowVerboseHint shifted everything below it by ten
lines, so every cmd/root.go:NNN reference written in this PR pointed at
unrelated code. The no-mutex safety argument is carried entirely by
those references, so a reviewer following them landed nowhere useful.

Replaced with function names, which do not rot.

…llapse

- TestRunRequestSubmit_SubmitPayload becomes a table over Azure and AWS.
  The AWS row is where locationType stops being a naive string(ws.CSP),
  so an Azure-only fixture left "AWS" -> "Aws" alive.
- The RequestDetails assertion now compares key counts, so an extra key
  in the payload fails instead of going unnoticed.
- Add a --reason "" case to the cancel and finalize arg tests, pinning
  the deliberate collapse of explicit-empty into unset.
- lastX() accessors return a pointer to a copy, not into the history
  slice's backing array, which append can reallocate under a held
  pointer.

COV-01: deleting the verbose-hint call site from Execute() is killed
only on the integration leg; the default local go test ./cmd/ loop
leaves it green.

COV-02: TestRunLogin_AutoConfiguresMissingProfile skips under a PTY, so
the auto-configure branch has no coverage there. survey reads os.Stdin
with no injectable seam, so this is accepted rather than fixed; the skip
comment now says so plainly.

…r fix